Skip to content

ci: don't compile gotestsum#1289

Merged
landism merged 1 commit into
masterfrom
matt/dont_compile_gotestsum
Mar 12, 2019
Merged

ci: don't compile gotestsum#1289
landism merged 1 commit into
masterfrom
matt/dont_compile_gotestsum

Conversation

@landism

@landism landism commented Mar 11, 2019

Copy link
Copy Markdown
Member

Problem:

the macos CI build keeps failing with errors like this:

#!/bin/bash -eo pipefail
go get -u gotest.tools/gotestsum
        go get: warning: modules disabled by GO111MODULE=auto in GOPATH/src;
	ignoring go.mod;
	see 'go help modules'
# cd .; git clone https://go.googlesource.com/sys /Users/distiller/go/src/golang.org/x/sys
Cloning into '/Users/distiller/go/src/golang.org/x/sys'...
fatal: remote error: Internal Server Error
package golang.org/x/sys/unix: exit status 128
Exited with code 1

Solution:
download gotestsum instead of go getting it

(also this step was taking 30-40 seconds, so we might as well not do that?)

@landism
landism force-pushed the matt/dont_compile_gotestsum branch from 656bb1e to 7133e09 Compare March 11, 2019 21:50
@landism
landism requested a review from nicks March 11, 2019 21:57
@landism
landism merged commit 6e02927 into master Mar 12, 2019
@landism
landism deleted the matt/dont_compile_gotestsum branch March 12, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants