hud: start up the hud server by default on port 10350#1327
Merged
Conversation
Contributor
Author
|
(i also like this pr as an example of how to move things out of up.go) |
jazzdan
approved these changes
Mar 15, 2019
jazzdan
left a comment
jazzdan
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but it doesn't seem like the thing that HeadsUpServerController reacts to (just the port to listen on?) can change at runtime. Is that planned for the future?
Contributor
Author
|
nope, right now it's just to get the init stuff out of the cli. it might make sense to give subscribers an Init hook |
nicks
force-pushed
the
nicks/ch1836/server
branch
from
March 15, 2019 18:55
c2a4236 to
ee9faae
Compare
nicks
force-pushed
the
nicks/ch1836/server
branch
from
March 15, 2019 21:22
ee9faae to
907e500
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @landism, @jazzdan,
Please review the following commits I made in branch nicks/ch1836/server:
c2a4236 (2019-03-15 14:32:58 -0400)
hud: start up the hud server by default on port 10350