Skip to content

build: customBuild now relies on $EXPECTED_REF env var (rather than $TAG)#1351

Merged
maiamcc merged 2 commits into
masterfrom
maiamcc/tag-env-var-to-ref
Mar 25, 2019
Merged

build: customBuild now relies on $EXPECTED_REF env var (rather than $TAG)#1351
maiamcc merged 2 commits into
masterfrom
maiamcc/tag-env-var-to-ref

Conversation

@maiamcc

@maiamcc maiamcc commented Mar 22, 2019

Copy link
Copy Markdown
Contributor

Hello @jazzdan, @dbentley,

Please review the following commits I made in branch maiamcc/tag-env-var-to-ref:

d7dcfca (2019-03-22 13:25:19 -0400)
build: customBuild now relies on $EXPECTED_REF env var (rather than $TAG)

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@maiamcc
maiamcc requested review from dbentley and jazzdan March 22, 2019 17:25
@maiamcc
maiamcc merged commit cb90b60 into master Mar 25, 2019
@maiamcc
maiamcc deleted the maiamcc/tag-env-var-to-ref branch March 25, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants