Skip to content

web: create preview pane#1437

Merged
hyu merged 8 commits into
masterfrom
dmiller/ch1958/create-preview-pane
Apr 5, 2019
Merged

web: create preview pane#1437
hyu merged 8 commits into
masterfrom
dmiller/ch1958/create-preview-pane

Conversation

@hyu

@hyu hyu commented Apr 4, 2019

Copy link
Copy Markdown
Contributor

I tried tab-like buttons for "Logs" and "Preview" view options.

  • In this PR, it's not obvious the view options are buttons. I'll address this in my next design pass.
  • When we have more than two views, this design will have to change.

2019-04-04 - preview

Nav Design Alternatives considered

I mocked up a design with the view options to the left of the sidebar, but it was a bit too visually obtrusive.

2019-04-04 - view options mock

@hyu
hyu requested review from jazzdan and nicks April 4, 2019 22:19

@jazzdan jazzdan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread web/src/PreviewPane.test.tsx Outdated
@nicks

nicks commented Apr 5, 2019

Copy link
Copy Markdown
Contributor

one major bug:
when the logs pane is focused, you can scroll with the mousewheel but there's no scrollbar.
when the logs pane is not focused, you can't scroll at all 😭 . and still no scrollbar

some minor issues:
when looking at all logs, and clicking the "Preview" button, i get a "No match" error
when looking at (Tiltfile) logs, and clicking the "Preview" button, I get a blank screen
when the right sidebar is taller than the screen, there's no scrollbar. there used to be a scrollbar before this PR, so this appears to be a regression

Comment thread web/src/HUD.scss Outdated
Comment thread web/src/HUD.tsx
Comment thread web/src/LoadingScreen.scss Outdated
Comment thread web/src/LogPane.scss Outdated
- only fixed items are sidebar and status
- show empty page when viewing resource with no endpoint
@hyu
hyu merged commit 662c86e into master Apr 5, 2019
@nicks
nicks deleted the dmiller/ch1958/create-preview-pane branch March 31, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants