build: in verbose mode, print what files we're syncing/where syncing them to [ch2130]#1463
Merged
Conversation
maiamcc
force-pushed
the
maiamcc/sync-transparency
branch
from
April 9, 2019 19:48
1e6abee to
7130e90
Compare
Contributor
Author
|
local container BaD: synclet BaD: |
dbentley
reviewed
Apr 10, 2019
| } | ||
|
|
||
| if len(toRemove) > 0 { | ||
| l.Verbosef("Deleting %d file(s) from container: %s", len(toRemove), cID.ShortStr()) |
Contributor
There was a problem hiding this comment.
Why verbose? This seems like good info to have in general. If the concern is length, I think there are ways to make it simpler.
In-container updating is fraught, and I'd rather overexplain (esp given comments we get like "I'm not sure sure what is happening or why")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @landism, @dbentley,
Please review the following commits I made in branch maiamcc/sync-transparency:
1e6abee (2019-04-09 15:45:33 -0400)
build: in verbose mode, print what files we're syncing/where syncing them to [ch2130]
Code review reminders, by giving a LGTM you attest that: