cli: fix missing dev suffix in version analytics#1488
Merged
Conversation
nicks
approved these changes
Apr 12, 2019
| return e == BuildInfo{} | ||
| } | ||
|
|
||
| func (e BuildInfo) FullVersion() string { |
Contributor
There was a problem hiding this comment.
Can we call it analytics version or smth? "full" is very vague
| assert.Equal(t, fmt.Sprintf("v%s", devVersion), string(provideWebVersion(provideBuildInfo()))) | ||
| } | ||
|
|
||
| func TestBuildVersion(t *testing.T) { |
Contributor
There was a problem hiding this comment.
This does not seem like a useful test. It's unlikely to catch an actual regression. A better test might be one that tests what analytics is sending
Contributor
There was a problem hiding this comment.
(a good rule of thumb : would this test have prevented this bug? In this case, the bug is in the interaction between two components, so a test that only exercises one does not really get at the problem)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.