sail: end-to-end sharing#1499
Merged
Merged
Conversation
Contributor
Author
|
with this pr, we're now at a place where we can replicate the data to the sail server, and view it in a UI served by the sail server. it's still super buggy and needs lots of work, particularly in
|
nicks
force-pushed
the
nicks/ch2240/sail
branch
from
April 16, 2019 18:45
501c173 to
0bfe326
Compare
jazzdan
approved these changes
Apr 16, 2019
|
|
||
| room := NewRoom(conn) | ||
| s.rooms[room.id] = room | ||
| log.Printf("newRoom: %s", room.id) |
Contributor
There was a problem hiding this comment.
There are a bunch of these logs: are they meant to be used long term? If so can we make them structured logs so they'd be easy to pick up in Honeycomb?
Contributor
Author
There was a problem hiding this comment.
yep, the logs are intentional. wanted to get something working and debuggable before we start thinking about logging strategy. a lot will need to change before we can even deploy this
| } | ||
|
|
||
| render() { | ||
| debugger |
nicks
force-pushed
the
nicks/ch2240/sail
branch
from
April 16, 2019 19:08
0bfe326 to
5c96207
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @jazzdan, @landism,
Please review the following commits I made in branch nicks/ch2240/sail:
501c173 (2019-04-16 14:35:10 -0400)
sail: end-to-end sharing