sail: more startup options and better cleanup#1511
Merged
Conversation
maiamcc
reviewed
Apr 22, 2019
| func contextWithCancel() (context.Context, func()) { | ||
| ctx, cancel := context.WithCancel(context.Background()) | ||
| defer cancel() | ||
| l := logger.NewLogger(logger.InfoLvl, os.Stderr) |
Contributor
There was a problem hiding this comment.
this should probably be common between this and cli/cli.go
Contributor
There was a problem hiding this comment.
hmm but there's not really a good place to put it, i'll leave it for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @maiamcc, @landism,
Please review the following commits I made in branch nicks/sailconfig:
35d3032 (2019-04-18 18:21:24 -0400)
sail: more startup options and better cleanup