sail: re-unify new room and room connect so that we can surface the sail url right away, w/o waiting for OnChange#1559
Merged
Conversation
Contributor
Author
|
The un-dumb version of #1557 |
nicks
approved these changes
Apr 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @nicks,
Please review the following commits I made in branch maiamcc/surface-url-right-away:
269580d (2019-04-30 15:53:19 -0400)
fix tests
b7fae20 (2019-04-30 15:47:12 -0400)
http new room and room connect are one step (but use persistent ctx for websocket)
c3638e5 (2019-04-30 15:40:46 -0400)
use SetUp to get ctx on the sail client
Code review reminders, by giving a LGTM you attest that: