build: don't skip ignored directories#1580
Merged
landism merged 1 commit intoMay 6, 2019
Merged
Conversation
nicks
approved these changes
May 3, 2019
Member
Author
|
For posterity: Nick pointed out that docker has a more optimized solution to this here. We should probably do that at some point, but merging this as-is for now just to make things work. |
landism
deleted the
mlandis/ch2425/tilt-does-not-correctly-interpret-in-dockerignore
branch
May 6, 2019 16:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might be mildly controversial. This is effectively just reverting #1445, which gave us a big build speedup in some cases. Unfortunately, it introduced a problem:
If, e.g., vigoda's .dockerignore has
*and!main.go, we'llfilepath.Walktovigoda, it will be ignored because it matches*, and we'll never descend intovigodato discovervigoda/main.go.This change makes the associated test go red -> green and also fixes the vigoda repro mentioned above.
We could be clever by parsing out the exclusions and descending more intelligently (or even only descending if there exists any
!at all), but that's a more complex fix, and it seems best for today to apply this cheap fix to make things work, even if it comes with a perf hit.