sail: add a staging server for testing SSL#1604
Merged
Merged
Conversation
nicks
commented
May 9, 2019
| resp, err := http.Post(u.String(), "text/plain", bytes.NewReader(reqJson)) | ||
| if err != nil { | ||
| return "", "", errors.Wrapf(err, "GET %s", u.String()) | ||
| return "", "", err |
Contributor
Author
There was a problem hiding this comment.
removed this wrapper because
- This isn't even a GET, so the message was wrong
- http.Post errors already include "post [url]", so this led to weird duplication
maiamcc
approved these changes
May 9, 2019
| *m = SailModeStaging | ||
| default: | ||
| return UnrecognizedWebModeError(v) | ||
| return UnrecognizedSailModeError(v) |
| func UnrecognizedSailModeError(v string) error { | ||
| return fmt.Errorf("Unrecognized sail mode: %s. Allowed values: %s", v, []SailMode{ | ||
| SailModeDefault, SailModeDisabled, SailModeLocal, SailModeProd, | ||
| SailModeDefault, SailModeDisabled, SailModeLocal, SailModeProd, SailModeStaging, |
Contributor
There was a problem hiding this comment.
nit: swap Prod and Staging so they're in a reasonable order
nicks
force-pushed
the
nicks/ch2495/staging
branch
from
May 9, 2019 21:47
cb9a7c3 to
8d1c47d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @maiamcc,
Please review the following commits I made in branch nicks/ch2495/staging:
cb9a7c3 (2019-05-09 16:41:03 -0400)
sail: add a staging server for testing SSL