web: analytics nudge in sidebar (placeholder, styling TBD) [ch2531]#1622
Merged
Conversation
maiamcc
changed the title
Contributor
Author
|
And here it is collapsed:
|
jazzdan
approved these changes
May 13, 2019
jazzdan
left a comment
jazzdan
left a comment
Contributor
There was a problem hiding this comment.
Should this be a popover rather than a part of the sidebar? Overall the code LGTM though.
| <div className="AnalyticsNudge" key="AnalyticsNudge"> | ||
| <div> | ||
| Congrats on your first Tilt resource 🎉 Help us help you: may we | ||
| collect anonymized data on your usage. (Read more{" "} |
Contributor
There was a problem hiding this comment.
Should this end in a question mark?
may we collect anonymized data on your usage?
Contributor
Author
There was a problem hiding this comment.
...GEEZ DAN THAT'S WHAT I SAID THE FIRST TIME WEREN'T YOU LISTENING 👀
Contributor
Author
|
I'm happy to have this be a popover! Idk how to do that nonsense am happy to learn :) am likely gonna not implement that in this PR, cuz again, trying to get the backend wired up, but will maybe do for future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @yuindustries, @jazzdan,
Styling TBD (look there's even a ticket for it) but this PR displays the analytics nudge in the sidebar. If it's a long list of entries, we show the nudge 3rd in the list to avoid it getting lost in the shuffle. Awkward left-border to make it visible even when the pane is collapsed. Enjoy this hot mess of CSS! (don't worry, this is all gated behind an env variable.)