integration: fix exec test#1625
Merged
Merged
Conversation
Prior to this change the exec test wasn't really testing exec. When we tried to do an exec update it would fail due to incompatibilites between GNU tar and busybox tar. This would cause the update to fall back to an image build, which caused the test to pass. Let's make sure that the pods dont change AND install GNU tar in the container so that the test passes. While this feels a little gross, it's at least testing more than it was.
nicks
approved these changes
May 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change the exec test wasn't really testing exec. When
we tried to do an exec update it would fail due to incompatibilites
between GNU tar and busybox tar. This would cause the update to fall
back to an image build, which caused the test to pass.
Let's make sure that the pods dont change AND install GNU tar in the
container so that the test passes.
While this feels a little gross, it's at least testing more than it was.
Discovered while looking in to #1611