web: use build error formatting for other errors too#1670
Merged
Conversation
maiamcc
approved these changes
May 21, 2019
maiamcc
left a comment
Contributor
There was a problem hiding this comment.
lgtm, tho may I see a screenshot?
Member
Author
added to description, though really it's just exactly how build errors look already |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The styling for errors in ErrorPane.scss applies to
<code>elements.For most of the types of error items we can show in ErrorPanes, we put them in
<p>elements and not<code>elements!It turns out that
<code>elements are generated by theAnsiLinesplitting we do for build errors.This means we get all kinds of fun things, like if a pod crashes with two log lines, we display them both and ignore the newline, so they're concatenated horizontally.
Since build errors have been styled (i.e., we actually define styles for them in the scss) and the other types haven't, I'm assuming we should make everything else match build error styling.
Note this also means I'm dropping the "Last log line" copy, because: