start.sh: fix quoting, kill underlying process on exit#1784
Merged
Conversation
Contributor
|
By the way @landism there are multiple copies of this file in the repo |
added 2 commits
June 27, 2019 12:42
landism
commented
Jun 27, 2019
| echo "$process_id" > process.txt | ||
| wait $process_id | ||
| EXIT_CODE=$? | ||
| wait $process_id && EXIT_CODE=$? || EXIT_CODE=$? |
Member
Author
There was a problem hiding this comment.
I broke this - when we killed the process to restart, wait returned a non-0 exit, so the script exited because of set -e
Contributor
There was a problem hiding this comment.
would it make sense to just set +e before the wait?
nicks
approved these changes
Jun 27, 2019
| echo "$process_id" > process.txt | ||
| wait $process_id | ||
| EXIT_CODE=$? | ||
| wait $process_id && EXIT_CODE=$? || EXIT_CODE=$? |
Contributor
There was a problem hiding this comment.
would it make sense to just set +e before the wait?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"$@"instead of$*to ensure that we run the command with the same quotes as the original command