engine: check if images still exist when deciding whether to build#1806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1768
Problem
When Tilt decides whether an image needs to build, it basically just checks whether it knows the id of a previous build that hasn't been invalidated. This only works on the assumption that it's a closed system. In reality, kubelet can come in and delete images to free up disk space, or the user could have manually deleted the image, or whatever. This leads to a build error when we try to use a ref that no longer exists.
Solution
When determining whether to build an image, check both whether we have an image id and whether that id points at an image that still exists.