tiltfile: handle duplicate resources without erroring#1854
Merged
Conversation
Member
|
well, that's a bummer. is there a valid use case for duplicate resources, or is this purely a matter of "well kubectl accepts my yaml - why won't tilt?" |
landism
approved these changes
Jul 15, 2019
Contributor
Author
|
ya, i think there are probably a lot of cases where people have scripts that pull in the same resource multiple times, and it's generally ok. It's only really a problem if the resources differ in some way maybe we should do a deep comparison and de-dupe |
|
In my case I call kubectl apply to yaml with namespace definition first and then kubectl apply to the whole folder that contains several objects, including the namespace. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @landism,
Please review the following commits I made in branch nicks/duplicate:
33d4bb1 (2019-07-15 10:21:19 -0400)
tiltfile: handle duplicate resources without erroring
fixes #1853
helps with #1852, until we find a better way to address this