Skip to content

tiltfile: handle duplicate resources without erroring#1854

Merged
nicks merged 1 commit into
masterfrom
nicks/duplicate
Jul 15, 2019
Merged

tiltfile: handle duplicate resources without erroring#1854
nicks merged 1 commit into
masterfrom
nicks/duplicate

Conversation

@nicks

@nicks nicks commented Jul 15, 2019

Copy link
Copy Markdown
Contributor

Hello @landism,

Please review the following commits I made in branch nicks/duplicate:

33d4bb1 (2019-07-15 10:21:19 -0400)
tiltfile: handle duplicate resources without erroring
fixes #1853
helps with #1852, until we find a better way to address this

@nicks
nicks requested a review from landism July 15, 2019 14:22
fixes #1853
helps with #1852, until we find a better way to address this
@nicks
nicks force-pushed the nicks/duplicate branch from 33d4bb1 to bdebb06 Compare July 15, 2019 14:26
@landism

landism commented Jul 15, 2019

Copy link
Copy Markdown
Member

well, that's a bummer. is there a valid use case for duplicate resources, or is this purely a matter of "well kubectl accepts my yaml - why won't tilt?"

@nicks

nicks commented Jul 15, 2019

Copy link
Copy Markdown
Contributor Author

ya, i think there are probably a lot of cases where people have scripts that pull in the same resource multiple times, and it's generally ok.

It's only really a problem if the resources differ in some way

maybe we should do a deep comparison and de-dupe

@nicks
nicks merged commit 88f5d8b into master Jul 15, 2019
@nicks
nicks deleted the nicks/duplicate branch July 15, 2019 15:06
@AleF83

AleF83 commented Jul 15, 2019

Copy link
Copy Markdown

In my case I call kubectl apply to yaml with namespace definition first and then kubectl apply to the whole folder that contains several objects, including the namespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tilt failed to create namespace

3 participants