engine/store: s/deployInfo/containerInfo, can attach multiple containerInfos to a BuildState if that target is deployed to multiple containers [ch3004]#1921
Merged
Conversation
dbentley
approved these changes
Jul 26, 2019
dbentley
left a comment
dbentley
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but I may have missed something, cause I haven't been in here that deep recently...
| // Check to see if there's a single, unambiguous Ready container | ||
| // in the given PodSet. If so, create a DeployInfo for that container. | ||
| func NewDeployInfo(iTarget model.ImageTarget, deployID model.DeployID, podSet PodSet) DeployInfo { | ||
| // IF all containers running the given image are ready, returns info for them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @landism, @dbentley,
Please review the following commits I made in branch maiamcc/build-state-container-info:
2cba776 (2019-07-26 14:42:13 -0400)
tests
0d8c430 (2019-07-26 14:39:29 -0400)
make containerInfo for all containers on pod
ca0d844 (2019-07-26 12:42:36 -0400)
store multiple container infos (theoretically)
b6a00b1 (2019-07-26 11:48:18 -0400)
s/deployInfo/containerInfo
Code review reminders, by giving a LGTM you attest that: