tiltfile: remove localPath#1981
Merged
Merged
Conversation
nicks
force-pushed
the
nicks/localpath
branch
2 times, most recently
from
August 2, 2019 22:51
07120dc to
9e6f442
Compare
Contributor
Author
|
(a lot of this code was for supporting the whole local_git_repo API, which we now discourage anyway) |
Contributor
|
@nicks I didn't realize that we still supported |
jazzdan
approved these changes
Aug 5, 2019
jazzdan
left a comment
jazzdan
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but looks like a real test failure there.
this abstraction just made things more complicated and we've been gradually moving away from it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @jazzdan,
Please review the following commits I made in branch nicks/localpath:
a24cb1f (2019-08-02 18:43:26 -0400)
tiltfile: remove localPath
this abstraction just made things more complicated and we've been gradually moving away from it