tiltfile: fast build deprecation date#2028
Merged
Merged
Conversation
Contributor
|
FWIW I've seen these code deadlines come and go maaaany times without any action. I think for this to be effective it also needs to be prioritized in the Tilt Roadmap. |
nicks
approved these changes
Aug 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feel free to reject the date, or even the fact of setting a hard deadline,
but I would love for us to actually get fast_build out of our codebase.
This PR puts a deprecation deadline in the fast_build deprecation warning.
Come 9/12, we'd remove tiltfile support for
fast_build, and remove FastBuild internally at our leisure.