tiltfile/engine: localresource execs in correct dir [ch3505]#2251
Merged
Conversation
jazzdan
approved these changes
Sep 24, 2019
|
|
||
| ps := build.NewPipelineState(ctx, 1, bd.clock) | ||
| ps.StartPipelineStep(ctx, "Running command: %v", c.Argv) | ||
| ps.StartPipelineStep(ctx, "Running command: %v (from %q)", c.Argv, wd) |
Contributor
There was a problem hiding this comment.
Suggested change
| ps.StartPipelineStep(ctx, "Running command: %v (from %q)", c.Argv, wd) | |
| ps.StartPipelineStep(ctx, "Running command: %v (in %q)", c.Argv, wd) |
| cmd := exec.CommandContext(ctx, c.Argv[0], c.Argv[1:]...) | ||
| cmd.Stdout = writer | ||
| cmd.Stderr = writer | ||
| if wd != "" { |
Contributor
There was a problem hiding this comment.
I don't think this does anything. If Dir is empty the command runs relative to the working directory, which is what the default behavior is anyways, since the empty value for a string in a struct is "".
added 2 commits
September 24, 2019 14:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @jazzdan, @dbentley,
Please review the following commits I made in branch maiamcc/workdir-local-resource:
158ba6c (2019-09-24 12:24:55 -0400)
run cmd from wd, test
77da300 (2019-09-24 11:58:58 -0400)
attach workdir to LocalTarget
Code review reminders, by giving a LGTM you attest that: