Skip to content

web: correctly build path when rendering snapshot that was made from …#2326

Merged
jazzdan merged 2 commits into
masterfrom
dmiller/ch3681/taking-a-snapshot-from-anything-except-root
Oct 14, 2019
Merged

web: correctly build path when rendering snapshot that was made from …#2326
jazzdan merged 2 commits into
masterfrom
dmiller/ch3681/taking-a-snapshot-from-anything-except-root

Conversation

@jazzdan

@jazzdan jazzdan commented Oct 11, 2019

Copy link
Copy Markdown
Contributor

…non-root path

@jazzdan
jazzdan requested a review from nicks October 11, 2019 16:20

@nicks nicks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test?

@jazzdan
jazzdan force-pushed the dmiller/ch3681/taking-a-snapshot-from-anything-except-root branch from b52962e to c1b3538 Compare October 14, 2019 15:15
@jazzdan

jazzdan commented Oct 14, 2019

Copy link
Copy Markdown
Contributor Author

@nicks added!

@jazzdan
jazzdan merged commit 666902b into master Oct 14, 2019
@nicks
nicks deleted the dmiller/ch3681/taking-a-snapshot-from-anything-except-root branch February 3, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants