tiltfile: extensions should reset state in OnStart#2349
Merged
Conversation
Contributor
Author
|
i need to think of a better way to manage extension state...one possibility is that all extensions should be non-stateful, and attach their state to the starlark thread. |
nicks
force-pushed
the
nicks/k8scontext
branch
from
October 15, 2019 17:53
17b2e34 to
101f7f3
Compare
jazzdan
approved these changes
Oct 15, 2019
nicks
force-pushed
the
nicks/k8scontext
branch
from
October 15, 2019 18:19
101f7f3 to
74a34f1
Compare
nicks
force-pushed
the
nicks/k8scontext
branch
from
October 15, 2019 18:26
74a34f1 to
7c878b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @jazzdan, @maiamcc,
Please review the following commits I made in branch nicks/k8scontext:
17b2e34 (2019-10-15 13:52:26 -0400)
tiltfile: extensions should reset state in OnStart