logstore: Add a concept of checkpoints and ContinuingStrings, for incremental log printing#2623
Merged
Conversation
…remental log printing
nicks
force-pushed
the
nicks/continuation
branch
from
December 4, 2019 16:28
349557c to
2b5127c
Compare
jazzdan
approved these changes
Dec 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @jazzdan,
Please review the following commits I made in branch nicks/continuation:
349557c (2019-12-04 11:27:30 -0500)
logstore: Add a concept of checkpoints and ContinuingStrings, for incremental log printing
ce0e01a (2019-12-04 11:20:10 -0500)
model: store logs by segment instead of by line
A key API we want to be able to support is "give me all the logs since checkpoint X".
Storing the logs in an append-only data structure makes this much easier to support,
even if it makes it a little bit harder to print the logs line-by-line.
Storing the logs line-by-line meant we had to do backtracking and make things mutable.