webview: remove build logs, and load them from the log store#2670
Merged
Conversation
nicks
force-pushed
the
nicks/spanlog4
branch
from
December 12, 2019 22:45
cdecbfa to
93705ae
Compare
this should remove even more redundancy from what we're sending, and set us up well for incremental log loading
nicks
force-pushed
the
nicks/spanlog4
branch
from
December 13, 2019 22:46
93705ae to
85d135a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @jazzdan, @hyu,
Please review the following commits I made in branch nicks/spanlog4:
cdecbfa (2019-12-12 16:39:08 -0500)
webview: remove build logs, and load them from the log store
this should remove even more redundancy from what we're sending, and
set us up well for incremental log loading