tiltfile: refactor local target tests to use assertNextManifest style tests#2731
Merged
jazzdan merged 3 commits intoJan 7, 2020
Merged
Conversation
nicks
approved these changes
Jan 7, 2020
| switch matcher := matcher.(type) { | ||
| case updateCmdHelper: | ||
| assert.Equal(f.t, matcher.cmd, lt.UpdateCmd.String()) | ||
| case depsHelper: |
Contributor
There was a problem hiding this comment.
this needs a default case that calls Fatal()
|
|
||
| mTop := f.loadResult.Manifests[1] | ||
| require.Equal(t, "toplvl-local", mTop.Name.String()) | ||
| mTop := f.assertNextManifest("toplvl-local", lt(updateCmd("echo hello world"), deps(f.JoinPath("foo/baz"), f.JoinPath("foo/a.txt")))) |
Contributor
There was a problem hiding this comment.
it might be simpler if the fixture does the JoinPaths?
| return updateCmdHelper{cmd} | ||
| } | ||
|
|
||
| type ltHelper struct { |
Contributor
There was a problem hiding this comment.
can we spell this out as localTarget? i'm not sure i'd ever remember what lt meant without digging around. i would assume it meant "less than"
| switch di := m.deployTarget.(type) { | ||
| case DockerComposeTarget: | ||
| return di.LocalPaths() | ||
| case LocalTarget: |
Contributor
There was a problem hiding this comment.
should we panic() in the default case, to prevent this from getting missed in the future?
nicks
deleted the
jazzdan/refactor_local_resource_tests_to_use_manifest_assertions
branch
February 3, 2022 16:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.