internal/engine/local: controller for local serve#2735
Merged
Conversation
jazzdan
approved these changes
Jan 8, 2020
| proc.doneCh = c.execer.Start(ctx, spec.ServeCmd, logger.Get(ctx).Writer(logger.InfoLvl), statusCh) | ||
| } | ||
|
|
||
| // lastProcess represents the last process |
Contributor
There was a problem hiding this comment.
Can we expand on this comment? Why do we need a sentinel struct to know when we've reached the end of the processes?
Contributor
Author
There was a problem hiding this comment.
Oh, it's not a sentinel struct. It's where we store info about the most recent exec, if any. Ideas for better names?
Contributor
There was a problem hiding this comment.
Ohh I see. mostRecentProcess? Or the extra verbose, non-Go-like mostRecentlyExecedProcess?
Contributor
Author
There was a problem hiding this comment.
Went for currentProcess, but happy to change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft.
Things that are missing that should be here before merging:
For a next PR: