local_resource: expand on sleep comment#2886
Merged
Merged
Conversation
nicks
approved these changes
Jan 31, 2020
| // HACK(maia): on initial build, give the file change a little extra time to | ||
| // propagate through, to increase the chance that we pick it up before we start | ||
| // the next build (otherwise, we may build that next resource twice). | ||
| // HACK(maia) If target A generates file X and target B depends on file X, it was common that on Tilt startup, |
Contributor
There was a problem hiding this comment.
anecdotally, i've seen this Sleep call be insufficient when inotify is under load.
One possible way to fix with is to introduce some kind of an fsync() primitive (like we have elsewhere) where we make some change in a temp directory and wait for it to propagate thru all relevant listeners (in this case, the Store state loop)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.