web: add a storybook for the log UI#2890
Merged
Merged
Conversation
Contributor
Author
|
will wait on your PR that moves the component |
Contributor
nicks
force-pushed
the
nicks/storybook
branch
from
February 4, 2020 22:22
407d914 to
c07ecbb
Compare
nicks
force-pushed
the
nicks/storybook
branch
from
February 4, 2020 22:24
c07ecbb to
d5f05f8
Compare
Contributor
Author
|
@hyu updated the PR! pls take another look |
hyu
approved these changes
Feb 5, 2020
hyu
left a comment
hyu
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Good reminder for me to put more into Storybook, too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @hyu,
Please review the following commits I made in branch nicks/storybook:
407d914 (2020-01-31 16:31:04 -0500)
web: add a storybook for the log UI
Code review reminders, by giving a LGTM you attest that: