engine: don't call KIND load if cluster ref provided; s/kindPush/kindLoad [ch4292]#2898
Merged
Conversation
Contributor
|
i don't think this is quite what we want. i'm almost done with the auto-detection and that will make things clearer. |
nicks
approved these changes
Feb 4, 2020
nicks
left a comment
nicks
left a comment
Contributor
There was a problem hiding this comment.
actually, on thinking about this, i'm ok with this
| ps.Printf(ctx, "Pushing to KIND") | ||
| err := ibd.kp.PushToKIND(ps.AttachLogger(ctx), ref) | ||
| isKind := ibd.env == k8s.EnvKIND5 || ibd.env == k8s.EnvKIND6 | ||
| if isKind && !iTarget.HasDistinctClusterRef() { |
Contributor
There was a problem hiding this comment.
can you move this into a separate shouldUseKINDLoad() method?
Contributor
Author
|
Will wait for #2899 and then rebase |
nicks
approved these changes
Feb 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @nicks, @landism,
Please review the following commits I made in branch maiamcc/skip-kind-load:
8543921 (2020-02-04 14:09:48 -0500)
engine: don't call KIND load if cluster ref provided; s/kindPush/kindLoad [ch4292]
Code review reminders, by giving a LGTM you attest that: