build: make custom_build play more nicely with local registries. Fixes #2928#2929
Merged
Conversation
jazzdan
approved these changes
Feb 11, 2020
Contributor
Author
|
I think this reaffirms my belief that custom_build needs to be redesigned...we've learned a lot how people want to use it, and the current options don't really map cleanly onto the different patterns. |
nicks
force-pushed
the
nicks/issue2928
branch
from
February 11, 2020 16:53
d2913fe to
b768ee1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @maiamcc, @jazzdan,
Please review the following commits I made in branch nicks/issue2928:
d2913fe (2020-02-11 11:42:22 -0500)
build: make custom_build play more nicely with local registries. Fixes #2928
Code review reminders, by giving a LGTM you attest that: