Skip to content

Add vertical separator between multiple PortForwardLinks#3005

Merged
wu-victor merged 3 commits into
masterfrom
victor-tilt/ch4269/no-spacing-between-multiple-k8s-port-forwards
Feb 24, 2020
Merged

Add vertical separator between multiple PortForwardLinks#3005
wu-victor merged 3 commits into
masterfrom
victor-tilt/ch4269/no-spacing-between-multiple-k8s-port-forwards

Conversation

@wu-victor

@wu-victor wu-victor commented Feb 22, 2020

Copy link
Copy Markdown
Contributor

Clubhouse story: https://app.clubhouse.io/windmill/story/4269/no-spacing-between-multiple-k8s-port-forwards

Multiple

Before / After Screenshot
Before multiple-before
After multiple-after

Single

Before / After Screenshot
Before single-before
After single-after

@wu-victor
wu-victor requested a review from hyu February 22, 2020 20:48
@wu-victor

Copy link
Copy Markdown
Contributor Author

@hyu : Does this work? It adds some space in the last portforwardlink at the right, not sure if that matters.

@hyu hyu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving this quick fix forward, @victorwuky!

Comment thread web/src/ResourceInfo.tsx
@wu-victor
wu-victor merged commit c097aec into master Feb 24, 2020
@wu-victor wu-victor changed the title Add space between multiple PortForwardLinks Add vertical separator between multiple PortForwardLinks Feb 24, 2020
@wu-victor
wu-victor deleted the victor-tilt/ch4269/no-spacing-between-multiple-k8s-port-forwards branch June 4, 2020 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants