Revert "engine: if we fail to inject the synclet into a resource, try to recover gracefully (#3050)"#3055
Merged
Merged
Conversation
nicks
approved these changes
Mar 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a user in #tilt reported consistent "ExecUpdater does not support
restart_container()step" errorseven tho they expected tilt to use the Synclet.
the reverted commit is the cause: as a prerequiste to using the synclet, we check
the last result for the k8s target to see if it has the
HasEligibleSyncletflag.However, this didn't work in practice because, when we construct a buildEntry,
we don't add k8s results to the buildStateSet;
no k8s result ever made it to the new code that checks the synclet eligibility flag.
will revisit this PR soon to make it do the right thing; for now, just revert to
fix the break.