Skip to content

k8s: add warnings if you're not using a local registry but should be#3104

Merged
nicks merged 1 commit into
masterfrom
nicks/ch5539/registry
Mar 23, 2020
Merged

k8s: add warnings if you're not using a local registry but should be#3104
nicks merged 1 commit into
masterfrom
nicks/ch5539/registry

Conversation

@nicks

@nicks nicks commented Mar 20, 2020

Copy link
Copy Markdown
Contributor

Hello @maiamcc,

Please review the following commits I made in branch nicks/ch5539/registry:

6838a15 (2020-03-20 18:28:36 -0400)
k8s: add warnings if you're not using a local registry but should be

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
nicks requested a review from maiamcc March 20, 2020 22:29

@maiamcc maiamcc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@nicks
nicks merged commit d7d9e07 into master Mar 23, 2020
@nicks
nicks deleted the nicks/ch5539/registry branch March 23, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants