Skip to content

store: add named execution modes#3154

Merged
nicks merged 1 commit into
masterfrom
nicks/enginemode
Mar 31, 2020
Merged

store: add named execution modes#3154
nicks merged 1 commit into
masterfrom
nicks/enginemode

Conversation

@nicks

@nicks nicks commented Mar 31, 2020

Copy link
Copy Markdown
Contributor

Hello @jazzdan, @maiamcc,

Please review the following commits I made in branch nicks/enginemode:

0f57573 (2020-03-31 12:30:42 -0400)
store: add named execution modes
Make the default mode ("up") on the CLI the same as the default mode in the engine

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

Make the default mode ("up") on the CLI the same as the default mode in the engine
@nicks
nicks requested review from jazzdan and maiamcc March 31, 2020 16:54
@nicks
nicks merged commit d559b99 into master Mar 31, 2020
@nicks
nicks deleted the nicks/enginemode branch March 31, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants