re-enable buildkit on minikube v1.8.0+. Fixes https://github.com/windmilleng/tilt/issues/3192#3198
Merged
Conversation
Contributor
Author
|
i didn't pick minikube v1.8.0 for any particular reason, it's just what I had on my machine and could verify with. (I couldn't figure out from the upstream ticket when this was fixed). We can move it earlier if someone asks for it, though minikube is pretty good about nudging people to upgrade |
nicks
force-pushed
the
nicks/ch6163
branch
2 times, most recently
from
April 10, 2020 14:53
a184f5f to
4679e5a
Compare
maiamcc
approved these changes
Apr 10, 2020
|
|
||
| import "context" | ||
|
|
||
| type FakeMinkube struct { |
Contributor
Author
There was a problem hiding this comment.
i'm amazed at how consistent we were
| "github.com/windmilleng/tilt/pkg/logger" | ||
| ) | ||
|
|
||
| var minMinikubeVersionBuildkit = semver.MustParse("1.8.0") |
Contributor
There was a problem hiding this comment.
the note in this PR about why v1.8.0 would be good to add here too, I think
Contributor
Author
There was a problem hiding this comment.
good point, comment added!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @jazzdan, @maiamcc,
Please review the following commits I made in branch nicks/ch6163:
ee9f862 (2020-04-10 10:17:26 -0400)
re-enable buildkit on minikube v1.8.0+. Fixes #3192
Code review reminders, by giving a LGTM you attest that: