web: user icon toggles Tilt Cloud Account menu#3201
Merged
Conversation
nicks
approved these changes
Apr 13, 2020
nicks
left a comment
nicks
left a comment
Contributor
There was a problem hiding this comment.
LGTM
most of my comments are minor style things. How do we expect this to behave within a snapshot?
| fill: ${Color.blue}; | ||
| transition: color ${AnimDuration.default} linear; | ||
|
|
||
| &:hover { |
Contributor
There was a problem hiding this comment.
i think you want this to be
${SidebarAccountButton}:hover &
to pin the hover effect to the button?
added 3 commits
April 14, 2020 19:42
improvements based on PR comments
Contributor
Author
|
There is a small unresolved discussion in this PR, but for the sake of momentum I'm merging this now. If needed, I'll create another PR to improve the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make it easier to sign up for Tilt Cloud, this PR adds a user icon at the top right of the screen. You click it, and toggle a menu that encourages you to sign up for Tilt Cloud. If you're already signed in, you can see your username and Tilt instance's team info.
Known Issues
Not Signed In
Signed In