Skip to content

tiltfile: distinguish host commands from container commands#3210

Merged
nicks merged 1 commit into
masterfrom
nicks/ch6271/cmd
Apr 15, 2020
Merged

tiltfile: distinguish host commands from container commands#3210
nicks merged 1 commit into
masterfrom
nicks/ch6271/cmd

Conversation

@nicks

@nicks nicks commented Apr 15, 2020

Copy link
Copy Markdown
Contributor

Hello @landism,

Please review the following commits I made in branch nicks/ch6271/cmd:

f7e7c0a (2020-04-15 11:41:41 -0400)
tiltfile: distinguish host commands from container commands

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
nicks requested a review from landism April 15, 2020 15:43
@nicks

nicks commented Apr 15, 2020

Copy link
Copy Markdown
Contributor Author

fixes #3189

@nicks
nicks force-pushed the nicks/ch6271/cmd branch from f7e7c0a to 9a6ca10 Compare April 15, 2020 16:04
@nicks
nicks force-pushed the nicks/ch6271/cmd branch from 9a6ca10 to 3b80c72 Compare April 15, 2020 16:32
@nicks
nicks merged commit b81141f into master Apr 15, 2020
@nicks
nicks deleted the nicks/ch6271/cmd branch April 15, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants