Skip to content

k8s: move forbidden runtime check to debug log #3281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jazzdan merged 1 commit into from
May 5, 2020
Merged

k8s: move forbidden runtime check to debug log #3281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/k8s/runtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func (r *runtimeAsync) Runtime(ctx context.Context) container.Runtime {
if isStatusErr {
status := statusErr.ErrStatus
if status.Code == http.StatusForbidden {
logger.Get(ctx).Warnf(
logger.Get(ctx).Debugf(
"Tilt could not read your node configuration\n"+
" Ask your Kubernetes admin for access to run `kubectl get nodes`.\n"+
" Detail: %v", err)
Expand Down
4 changes: 2 additions & 2 deletions internal/k8s/runtime_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
ktesting "k8s.io/client-go/testing"
)

func TestRuntimeForbidden(t *testing.T) {
func TestRuntimeReadNodeConfig(t *testing.T) {
cs := &fake.Clientset{}
cs.AddReactor("*", "*", func(action ktesting.Action) (handled bool, ret runtime.Object, err error) {
return true, nil, newForbiddenError()
Expand All @@ -24,7 +24,7 @@ func TestRuntimeForbidden(t *testing.T) {
runtimeAsync := newRuntimeAsync(core)

out := &bytes.Buffer{}
l := logger.NewLogger(logger.InfoLvl, out)
l := logger.NewLogger(logger.DebugLvl, out)
ctx := logger.WithLogger(context.Background(), l)
runtime := runtimeAsync.Runtime(ctx)
assert.Equal(t, container.RuntimeReadFailure, runtime)
Expand Down