Skip to content

make: fix release#3302

Merged
landism merged 3 commits into
masterfrom
matt/fix_release
May 8, 2020
Merged

make: fix release#3302
landism merged 3 commits into
masterfrom
matt/fix_release

Conversation

@landism

@landism landism commented May 7, 2020

Copy link
Copy Markdown
Member

No description provided.

@landism
landism requested a review from maiamcc May 7, 2020 21:25

@maiamcc maiamcc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lollll nice.

Could you add error handling though? the script should barf if version == "". (also mayyybe if no token is found? that seems less likely, but fairly possible on a developer's machine.)

but most helpful thing would be to print the response body if we get a non-200 error code.

@landism

landism commented May 8, 2020

Copy link
Copy Markdown
Member Author

Could you add error handling though? the script should barf if version == "". (also mayyybe if no token is found? that seems less likely, but fairly possible on a developer's machine.)

done, good call

but most helpful thing would be to print the response body if we get a non-200 error code.

That's what curl -S does, but the response body wasn't useful enough. Added some more language for this case.

@landism
landism merged commit 5e26102 into master May 8, 2020
@landism
landism deleted the matt/fix_release branch May 8, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants