Skip to content

Update upgrade docs as soon as possible#3308

Merged
wu-victor merged 2 commits into
masterfrom
upgrade-docs-as-soon-as-possible
May 11, 2020
Merged

Update upgrade docs as soon as possible#3308
wu-victor merged 2 commits into
masterfrom
upgrade-docs-as-soon-as-possible

Conversation

@wu-victor

Copy link
Copy Markdown
Contributor

No description provided.

@wu-victor

Copy link
Copy Markdown
Contributor Author

@maiamcc : I see https://github.com/windmilleng/tilt.build/pull/571/files hasn't been merged yet, but at least one person in Slack seems to have already seen 0.13.5, probably due to upgrade nudge, so I'm guessing they had to manually know to change 0.13.4 to 0.13.5 when copying pasting the upgrade command from https://docs.tilt.dev/upgrade.html.

Ideally https://docs.tilt.dev/upgrade.html can be updated automatically whenever there's a new release of windmilleng/tilt. Should we scope a story to do that soon-ish?

@wu-victor
wu-victor requested a review from maiamcc May 8, 2020 13:51

@maiamcc maiamcc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay yesterday, I put up PRs, was waiting on review, and then my workday ended.

Comment thread CONTRIBUTING.md Outdated
the [default dev version](internal/cli/build.go),
and the [installer version](scripts/install.sh).

The [upgrade docs](https://github.com/windmilleng/tilt.build/blob/master/docs/upgrade.md)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fwiw this looks like an additional checklist item, which it isn't -- maybe put the "asap-ness" clause in the above paragraph.

@maiamcc

maiamcc commented May 8, 2020

Copy link
Copy Markdown
Contributor

Thinking more, maybe the most useful thing here would be specifying that Tilters don't need to wait on review for version bump PRs.

@wu-victor
wu-victor requested a review from nicks May 8, 2020 15:23
@wu-victor

Copy link
Copy Markdown
Contributor Author

Thinking more, maybe the most useful thing here would be specifying that Tilters don't need to wait on review for version bump PRs.

@maiamcc : Sure. I'm always supportive of being more prescriptive if it is a very operationally focused. cc @nicks as well.

See latest update.

@wu-victor
wu-victor merged commit 290c355 into master May 11, 2020
@nicks

nicks commented May 11, 2020

Copy link
Copy Markdown
Contributor

sgtm

@wu-victor
wu-victor deleted the upgrade-docs-as-soon-as-possible branch June 4, 2020 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants