Skip to content

web: clearer copy on tilt cloud signin/link modal [ch6917]#3311

Merged
maiamcc merged 2 commits into
masterfrom
maiamcc/link-to-tc
May 11, 2020
Merged

web: clearer copy on tilt cloud signin/link modal [ch6917]#3311
maiamcc merged 2 commits into
masterfrom
maiamcc/link-to-tc

Conversation

@maiamcc

@maiamcc maiamcc commented May 8, 2020

Copy link
Copy Markdown
Contributor

Hello @hyu, @vw, @nicks,

Please review the following commits I made in branch maiamcc/link-to-tc:

2593168 (2020-05-08 16:21:30 -0400)
web: clearer copy on tilt cloud signin/link modal [ch6917]

addresses #3307

Comment thread web/src/SidebarAccount.tsx Outdated

@hyu hyu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I agree with Victor's comment to further shorten the button text.

Co-authored-by: Victor Wu <victor@tilt.dev>
@maiamcc

maiamcc commented May 11, 2020

Copy link
Copy Markdown
Contributor Author

Oh whoops I forgot to merge this 😅

@maiamcc
maiamcc merged commit 7fdc90c into master May 11, 2020
@maiamcc
maiamcc deleted the maiamcc/link-to-tc branch May 11, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants