Skip to content

hud: better support for windows terminals#3315

Merged
nicks merged 1 commit into
masterfrom
nicks/chars
May 11, 2020
Merged

hud: better support for windows terminals#3315
nicks merged 1 commit into
masterfrom
nicks/chars

Conversation

@nicks

@nicks nicks commented May 8, 2020

Copy link
Copy Markdown
Contributor

Hello @hyu, @landism,

Please review the following commits I made in branch nicks/chars:

22b673d (2020-05-08 22:25:45 -0400)
hud: better support for windows terminals

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
nicks requested review from hyu and landism May 8, 2020 22:26
@nicks

nicks commented May 8, 2020

Copy link
Copy Markdown
Contributor Author

snip1
snip2

@nicks
nicks merged commit 399f64e into master May 11, 2020
@nicks
nicks deleted the nicks/chars branch May 11, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants