Skip to content

engine: fix some improper format strings#3318

Merged
nicks merged 1 commit into
masterfrom
nicks/errorf
May 9, 2020
Merged

engine: fix some improper format strings#3318
nicks merged 1 commit into
masterfrom
nicks/errorf

Conversation

@nicks

@nicks nicks commented May 9, 2020

Copy link
Copy Markdown
Contributor

Hello @nicks,

Please review the following commits I made in branch nicks/errorf:

be16919 (2020-05-08 20:46:59 -0400)
engine: fix some improper format strings

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks

nicks commented May 9, 2020

Copy link
Copy Markdown
Contributor Author

this was leading to some minor escaping issues that were bothering me

@nicks
nicks merged commit 947966d into master May 9, 2020
@nicks
nicks deleted the nicks/errorf branch May 9, 2020 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant