Skip to content

k8s: log client timeout#3323

Merged
landism merged 2 commits into
masterfrom
matt/log_upsert_timeout
May 12, 2020
Merged

k8s: log client timeout#3323
landism merged 2 commits into
masterfrom
matt/log_upsert_timeout

Conversation

@landism

@landism landism commented May 11, 2020

Copy link
Copy Markdown
Member

Problem

When we time out a k8s upsert, we log this:

Build Failed: kubectl apply:
stderr: : signal: killed

which doesn't indicate what killed it or why

Solution

log this: Killed kubectl. Hit timeout of 15s.

@landism
landism requested review from jazzdan and maiamcc May 11, 2020 20:46

@maiamcc maiamcc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread internal/k8s/client_test.go Outdated
@landism
landism merged commit 2633cfe into master May 12, 2020
@landism
landism deleted the matt/log_upsert_timeout branch May 12, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants