Skip to content

k8s: Reset() the rest mapper if it fails to map an existing type. Fixes https://github.com/windmilleng/tilt/issues/3325#3339

Merged
nicks merged 1 commit into
masterfrom
nicks/ch6999
May 14, 2020
Merged

k8s: Reset() the rest mapper if it fails to map an existing type. Fixes https://github.com/windmilleng/tilt/issues/3325#3339
nicks merged 1 commit into
masterfrom
nicks/ch6999

Conversation

@nicks

@nicks nicks commented May 14, 2020

Copy link
Copy Markdown
Contributor

Hello @maiamcc,

Please review the following commits I made in branch nicks/ch6999:

1d6f85d (2020-05-14 10:52:37 -0400)
k8s: Reset() the rest mapper if it fails to map an existing type. Fixes #3325

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
nicks requested a review from maiamcc May 14, 2020 14:53

@maiamcc maiamcc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh nice, this fix is way simpler than I anticipated! Did you test it with the repro case in #3325 or should I?

@nicks

nicks commented May 14, 2020

Copy link
Copy Markdown
Contributor Author

Yes! I tested it with tilt ci. I actually created a small integration test framework with tilt ci just to test this, but this specific example was slower than I wanted (i.e., it takes about 90 seconds to run) so i kicked it out of the PR

@nicks
nicks merged commit b4f6cd3 into master May 14, 2020
@nicks
nicks deleted the nicks/ch6999 branch May 14, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Perma-pending resource when using Kafka CRD (b/c of CRD race condition?)

2 participants