Skip to content

Prefer the Scoop installer over our hand-rolled installer#3351

Merged
nicks merged 1 commit into
masterfrom
nicks/ch7042
May 19, 2020
Merged

Prefer the Scoop installer over our hand-rolled installer#3351
nicks merged 1 commit into
masterfrom
nicks/ch7042

Conversation

@nicks

@nicks nicks commented May 18, 2020

Copy link
Copy Markdown
Contributor

Hello @jazzdan, @landism,

Please review the following commits I made in branch nicks/ch7042:

951e577 (2020-05-18 22:02:12 -0400)
Prefer the Scoop installer over our hand-rolled installer

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
nicks requested review from jazzdan and landism May 18, 2020 22:03

@jazzdan jazzdan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, what a great scoop @nicks!

@nicks

nicks commented May 18, 2020

Copy link
Copy Markdown
Contributor Author

🍨

@nicks
nicks merged commit 6a25739 into master May 19, 2020
@nicks
nicks deleted the nicks/ch7042 branch May 19, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants