Skip to content

nodejs: pin to node 12.16#3382

Merged
nicks merged 1 commit into
masterfrom
nicks/node12
May 27, 2020
Merged

nodejs: pin to node 12.16#3382
nicks merged 1 commit into
masterfrom
nicks/node12

Conversation

@nicks

@nicks nicks commented May 27, 2020

Copy link
Copy Markdown
Contributor

Hello @nicks,

Please review the following commits I made in branch nicks/node12:

7dddf50 (2020-05-27 11:26:58 -0400)
nodejs: pin to node 12.16

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks

nicks commented May 27, 2020

Copy link
Copy Markdown
Contributor Author

here's the underlying issue
nodejs/node#32852

it looks like the node 12.17 release last night broke this too

@nicks
nicks merged commit 299c634 into master May 27, 2020
@nicks
nicks deleted the nicks/node12 branch May 27, 2020 15:42
nicks added a commit that referenced this pull request May 27, 2020
nicks added a commit that referenced this pull request May 27, 2020
* Revert "nodejs: pin to node 12.16 (#3382)"

This reverts commit 299c634.

* upgrade babel-preset env to 7.9.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant