web: fix fallback log styling when there are debug logs#3453
Merged
Conversation
Contributor
Author
|
still not great, but at least not totally broken |
jazzdan
approved these changes
Jun 12, 2020
jazzdan
left a comment
jazzdan
left a comment
Contributor
There was a problem hiding this comment.
I have no idea what's happening here but seems safe to me!
Contributor
Author
|
we do some tricks with margin so that the fallback reason log (the stuff with the blue highlight) is flush against the build-reason bar this tries to make sure we only do these tricks if we're close to the build-reason bar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @jazzdan, @hyu,
Please review the following commits I made in branch nicks/ch7547:
0dd5abb (2020-06-12 14:42:30 -0400)
web: fix fallback log styling when there are debug logs
Code review reminders, by giving a LGTM you attest that: