Skip to content

vendor: go-tty#3462

Merged
nicks merged 1 commit into
masterfrom
nicks/tty
Jun 15, 2020
Merged

vendor: go-tty#3462
nicks merged 1 commit into
masterfrom
nicks/tty

Conversation

@nicks

@nicks nicks commented Jun 15, 2020

Copy link
Copy Markdown
Contributor

Hello @nicks,

Please review the following commits I made in branch nicks/tty:

fe5e202 (2020-06-15 15:41:10 -0400)
vendor: go-tty

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks

nicks commented Jun 15, 2020

Copy link
Copy Markdown
Contributor Author

going to use this for some terminal prompt stuff

@nicks
nicks merged commit ab41e7b into master Jun 15, 2020
@nicks
nicks deleted the nicks/tty branch June 15, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant